Hi,
Gerrit Voss wrote:
> On Thu, 2008-06-19 at 09:15 -0500, Carsten Neumann wrote:
>> Gerrit Voss wrote:
>>> hmm, something seems to be slightly off, your commit still had both
>>> items unresolved ?? Or am I missing something. At least the generate
>>> part seems to be inactive as far as I can tell.
>> this must be a case of me being thick, but I don't get what you are
>> referring to here, sorry.
>> If a pointer field has custom access no functions are generated, for the
>> other two access types they are generated. Lines 380-450 of Field.py
>> have the relevant code for that. This sets the generate<FuncName>
>> variables which are tested in the template files.
>> BTW these variables are not new, they were called write<FuncName>
>> before, but I had renamed them to match the option in the .fcd files -
>> which does not exist anymore, patch to go back to use write<FuncName> is
>> attached (there is no difference in the generated code).
>> The reason for not testing the access type in the template files is that
>> nullcheck and std access produce different sets of functions, so one
>> needs finer control here anyways.
>
> what confused me was this part of your commit
> (TemplateFieldContainerBase_h.txt) or the last part of the attached
> patch:
[SNIP]
> for custom access it checks the generate flag which is never set in
> this case, as you pointed out and what my 'inactive' comment referred
> to.
doh, ok that makes little sense indeed, I'll clean that up. Thanks!
>> Why they produce different sets of
>> functions is not clear to me, but the last time I asked about it your
>> answer seemed to imply it was on purpose so I left it alone ;)
>
> because you can edit the field directly. Mainly I just wanted to keep
> the basic interface one would typically expect to find for a
> fieldcontainer's pointer field, e.g. add/sub/clear. IIRC the additional
> one or two (e.g. remove/replace) came from special cases. I'll check if
> they are still needed, and if not I'll remove them.
ok,
Carsten
-------------------------------------------------------------------------
Check out the new SourceForge.net Marketplace.
It's the best place to buy or sell services for
just about anything Open Source.
http://sourceforge.net/services/buy/index.php
_______________________________________________
Opensg-core mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensg-core
