Carsten Neumann wrote:
        Hello Marcus,

Marcus Lindblom wrote:
Carsten Neumann wrote:
I forgot to mention in the commit message that this makes the SharePtrGraphOp fairly slow (at also seems to share a *lot* more [1]), do we want to remove it from the default graph ops ?
I think it could be useful in those cases where you have loops.

Perhaps softening the perf-hit by:
 * Making the tracking optional?
hm, maybe, but since I think the default should be enabled tracking, I wonder if it is worth the effort, I mean who is going to make use of that option?
Oh. Sorry. Darnit. I misread your initial post, and my reply was just gibberish. :(

No, right, it doesn't make sense to add the flag. And yeah, removing from default is probably a good idea, if it is very slow and the common case is that it doesn't get much work done.

However, it is a breaking change (as some might get performance losses on their existing code, due to the lack of sharing optimizations) so the change in behaviour needs to be broadcast pretty well.

Cheers,
/Marcus
------------------------------------------------------------------------------
This SF.net email is sponsored by:
SourcForge Community
SourceForge wants to tell your story.
http://p.sf.net/sfu/sf-spreadtheword
_______________________________________________
Opensg-core mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensg-core

Reply via email to