Hi, On Mon, 2009-06-15 at 20:14 -0500, Carsten Neumann wrote: > Hi all, > > I'd like to remove the childparentype entry in the .fcd AFAICS its only > use is to generate a typedef in the FieldTraits<> for the generated > container: > > typedef @!ChildFiedParent!@ *ParentType; > > - why is it a pointer type, i.e. why the "*" ? typo? > - quick grepping through the code did not turn up any uses...
> Last two points also apply to the parentfieldcard entry in .fcd, so I'd > remove that as well. > > Any objections, or arguments why that would be a bad idea? > if they are not used, most likely it was old stuff anyway, so yes they can be removed. Just one wish, if you ask these questions it is a lot easier to judge what actually changed if the attached patches don't contain cosmetic changes. Moving whole blocks around requires manually checks if there were actual changes inside them. E.g. nothing really substantial changed inside TemplateFieldContainerBase_cpp.txt. kind regards, gerrit ------------------------------------------------------------------------------ Crystal Reports - New Free Runtime and 30 Day Trial Check out the new simplified licensing option that enables unlimited royalty-free distribution of the report engine for externally facing server and web deployment. http://p.sf.net/sfu/businessobjects _______________________________________________ Opensg-core mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensg-core
