Hi, On Apr 15, 2011, at 7:18, Carsten Neumann <[email protected]> wrote:
> Hello Gerrit, > > On 04/14/2011 03:02 AM, Gerrit Voss wrote: >> - Log ----------------------------------------------------------------- >> commitdiff: >> http://opensg.git.sourceforge.net/git/gitweb.cgi?p=opensg/opensg;a=commitdiff;h=6eb7a447866343c04e924cbea983cf2995c82590 >> commit 6eb7a447866343c04e924cbea983cf2995c82590 >> Author: gerrit<[email protected]> >> Date: Thu Apr 14 16:00:24 2011 +0800 >> >> fixed: minor compile problems > > sorry about the breakage. Most of the changes i understand, but this one in > the ogre loader: > > OgreSkeletonReader::readAnimationLink(void) > { > std::string skelName = readString(_is); > - Real32 scale = readReal32(_is); > +#ifndef OSG_OGRE_SILENT > + Real32 scale = > +#endif > + readReal32(_is); > > is this to avoid an unused variable warning? Why does it not affect skelName > which is also only used in the log message? my guess because string is not a pod, so the compiler can't be sure of sideeffects, for pods like float he can ;) > Can we use osgSinkUnusedWarning (from OSGConecptPropertyChecks.h) instead > [1], I find that more readable than using CPP to kill half lines ;) fine with me, wasn't aware of it ;) will use it in the future ;) kind regards gerrit ------------------------------------------------------------------------------ Benefiting from Server Virtualization: Beyond Initial Workload Consolidation -- Increasing the use of server virtualization is a top priority.Virtualization can reduce costs, simplify management, and improve application availability and disaster protection. Learn more about boosting the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev _______________________________________________ Opensg-core mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensg-core
