Hello,
On 11/14/2013 04:04 AM, Gundel Dunkel wrote:
> I have a request for a change in CMake/OSGConfigurePackages.cmake.
> The boost library selection settings are hardcoded at the moment:
> SET(Boost_USE_MULTITHREADED ON )
> IF(NOT Boost_USE_STATIC_LIBS)
> SET(Boost_USE_STATIC_LIBS OFF CACHE INTERNAL "")
> ENDIF(NOT Boost_USE_STATIC_LIBS)
> (By the way, the IF statement is redundant, because this is the default
> semantics for cache variables.)
> It is much better to give a user the chance to change the settings at will:
> SET(Boost_USE_MULTITHREADED ON CACHE BOOL "boost built with
> multithreading support")
> SET(Boost_USE_STATIC_LIBS OFF CACHE BOOL "boost built as static
> library")
> SET(Boost_USE_STATIC_RUNTIME OFF CACHE BOOL "boost built against
> static msvcrt")
> Now a user can change the settings in cmake if necessary. And the
> default settings are set as before.
> You can set the variables as advanced if you wish using mark_as_advanced():
> mark_as_advanced(Boost_USE_MULTITHREADED Boost_USE_STATIC_LIBS
> Boost_USE_STATIC_RUNTIME)
> Could you please make the boost setting more user friendly?
hmm, I'm not certain if that would do more than *only* improve a users
chance of shooting themselves in the foot. Using static boost libs for
OpenSG is untested AFAIK, the multithreading settings should be
consistent with the way OpenSG is built and I'm not even sure about the
implications of using a static runtime for boost in this context.
So my gut feeling (without having investigated this further) is that
while we could give users a choice here, it has the potential of giving
a false sense of choice, i.e. in practice the only settings that
actually work would be the ones we currently enforce.
Do you have any experience that shows other settings still result in
correctly working OpenSG libraries? That would go a long way towards
putting my worries at ease. Thanks!
Cheers,
Carsten
------------------------------------------------------------------------------
DreamFactory - Open Source REST & JSON Services for HTML5 & Native Apps
OAuth, Users, Roles, SQL, NoSQL, BLOB Storage and External API Access
Free app hosting. Or install the open source package on any LAMP server.
Sign up and see examples for AngularJS, jQuery, Sencha Touch and Native!
http://pubads.g.doubleclick.net/gampad/clk?id=63469471&iu=/4140/ostg.clktrk
_______________________________________________
Opensg-core mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensg-core
