Thanks Gerrit.  :)

Have you thought of a way to disable warnings for the IDE? Maybe a #define, OSG_DISABLE_WARNINGS ?

Gerrit Voss wrote:

Hi,

ok as some people already notice I finished walking through this
patch ;-). Just for the records, I did some changes which did
not influence the result of prohibiting warnings, so 99% of
the changes were applied in one or the other way. Some small chunks
I did not apply as of now were those that had nothing to do with
warnings and seemed to be left overs (e.g. for BinaryDataHandler,
or some of the vector stuff). Some are still pending (they did not
pop during the lib build) but might come up during the test builds,
which are also still pending. The two big blocks I have to check further
are the configure changes (adding the --warning-as-errors switch) and
the changes to OSGConfig.h. For the OSGConfig.h stuff I currently don't
have a nice solution (the warning level switchings were moved to the
make system) as I don't like the idea of disabling stuff for all the
users of this include files. So those of you who use the Microsoft IDE,
there might be some more warnings coming up, I'll try to find a solution
for this ;-)
regards,
  gerrit


On Thu, 2004-01-15 at 18:53, Gerrit Voss wrote:

Hi,

ok I'll walk though the patches and apply them.

gerrit

On Thu, 2004-01-15 at 14:57, Chad Austin wrote:

I submitted a patch to OpenSG early in November that fixes all of the warnings in OSGBase and OSGSystem (and more!) at warning level 3 in VC71. This also fixes tons of warnings in gcc 3.3 (-Wall) which basically make developing OpenSG applications unbearable for me, unless I copy my checked out and modified source tree around to different computers. I'm of the philosophy that you should address all of your compiler's warnings 1) so that you can see errors and more important warnings more clearly and 2) because they almost always mean something. Speaking of which, some warnings showed that one of the test programs didn't work the way the author intended.

Anyway, as far as I can tell, nobody has even looked at the patch. I've since made other changes to my source tree, but they get totally lost in the warning-specific changes. Would someone review and commit or at least bring up issues with the patch so that I can address them?

I know it's incredibly boring (I've done my share of code reviews), but getting these changes checked in is important to me and everyone else who is inundated with pages and pages of warning output when using or building OpenSG.

The patch is at: http://sourceforge.net/tracker/?func=detail&aid=836701&group_id=5283&atid=305283

Thanks,
Chad



-------------------------------------------------------
This SF.net email is sponsored by: Perforce Software.
Perforce is the Fast Software Configuration Management System offering
advanced branching capabilities and atomic changes on 50+ platforms.
Free Eval! http://www.perforce.com/perforce/loadprog.html
_______________________________________________
Opensg-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensg-users



-------------------------------------------------------
This SF.net email is sponsored by: Perforce Software.
Perforce is the Fast Software Configuration Management System offering
advanced branching capabilities and atomic changes on 50+ platforms.
Free Eval! http://www.perforce.com/perforce/loadprog.html
_______________________________________________
Opensg-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensg-users




-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn
_______________________________________________
Opensg-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensg-users



-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn
_______________________________________________
Opensg-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensg-users

Reply via email to