Hi,
the code in Experimental/NewAction allows for more flexible scenegraph
traversals.
Nice work!
But there are some minor bugs:
* In OSGActorBase.h the internal class ActorBaseState (line 72) is
missing DLL modifiers
class OSG_SYSTEMLIB_DLLMAPPING ActorBaseState
( I get unresolved references when defining actors in another DLL
using Windows VC 7.1)
* In OSGNewActionBase.cpp the methods findBasicActor (line 328) /
findExtendActor (line 246) return an index wrong by one
"
UInt32 NewActionBase::findBasicActor(BasicActorBase *pActor) const
{
BasicActorStoreConstIt itActors = _basicActors.begin();
BasicActorStoreConstIt endActors = _basicActors.end ();
UInt32 pos = 0;
bool found = false;
for(; (itActors != endActors) && !found; ++itActors, ++pos)
{
if(*itActors == pActor)
found = true;
}
return (found ? pos : TypeTraits<UInt32>::getMax());
}
"
should have a "break;" after "found=true;"
(I get crashes when using subActor / subBasicActor.)
Thanks,
Christoph
-------------------------------------------------------
This SF.net email is sponsored by Demarc:
A global provider of Threat Management Solutions.
Download our HomeAdmin security software for free today!
http://www.demarc.com/Info/Sentarus/hamr30
_______________________________________________
Opensg-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensg-users
