On 1/5/07, Carsten Neumann <[EMAIL PROTECTED]> wrote:
Hi Daniel,
[EMAIL PROTECTED] wrote:
> Author: dshipton
> Date: Fri Jan 5 16:01:18 2007
> New Revision: 468
> Trac changeset: http://opensg.vrsource.org/trac/changeset/468
> ViewVC:
http://realityforge.vrsource.org/viewvc/opensg?view=rev&revision=468
>
> Modified:
[snip]
> Log:
> Use the standard C++ headers cassert and cerrno instead of the old
pre-standard ones that pollute the global namespace.
> This is in reference to Ticket #128.
I'm certainly not opposed to these changes in principle, but looking at
the diffs you just seemed to change the include statements, so I'm
wondering if this still compiles ?
AFAIK libstdc++ that comes with gcc still has all the symbols in global
namespace (as well as in std::) when using the c++ headers, that is
because they need support from the C library to get it right, IIRC. So
compiling with gcc won't show if the patch introduces any problems, and
if it does not, why not simply remove the includes alltogether as they
do not seem to be needed ?
Sorry for the late reply...
I actually took on this ticket to see if I could get rid of some headers for
the Windows build. In the end, it didn't help but that is what Dirk is for
:)
As I was going through this process I did notice that it looked like some of
these
includes were not being used. I also changed a few over to using headers
that
OpenSG already has (time.h->OSGTime.h).... In short, some time might need to
be
spent scrubbing unused/improperly used includes.
-Dan
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Opensg-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensg-users
