Hi Dirk,
On 3/20/07, Dirk Reiners <[EMAIL PROTECTED]> wrote:
Hi Olavo,
Olavo Belloc wrote:
> Hi Dirk,
>
> I didnt receive any comments on that until now. I know you are busy, and
> my intention on forwarding this to you in particular is not to hurry you
> up.. =)
Well, that's how it works, though. ;)
> Hi Dirk,
>
> I have been doing all the necessary modifications. As you can see, it's
> taking a while.. Most of the job is already done, and here in my
> computer, I can already use the BalancedMW in stereo and thats fine.
> Now, I am currently porting the Experimental/ShadowMapViewport and
> Experimental/ShadowViewport viewports to use the activate/deactivate
> method. They are working already, but with some issues..
>
> When modifying the SoftFirstW and BalancedMW, sometimes it was necessary
> to setup the read buffer (glReadBuffer) to the appropriate viewport to
> get the image from it. So, I have done this by including the
> glReadBuffer() together with glDrawBuffer() into the
> activate/deactivate() methods of the StereoBufferVP.. and I dont think
> it was good solution..was it?
In general I think that should be ok. Why do you think it's bad?
Well, there is no situation when its necessary to change both read/draw
buffers at the same time. So, when its necessary to change only one of
those, the activate method must be used, and both are changed. So I though
it could cause some performance issues (?). I am not sure of that.
Also, the Experimental shadow viewports inherits the
> StereoBufferViewport and changes the size of the viewport very
> frequently, and every time it does it, i need to call the activate
> method, and this sets and unsets the buffer unnecessary.. because only
> the size of the viewport was changed.
>
> So, I would like to ask if these issues are not so big and can be
> ignored, or it would be better to change the activate/deactivate method
> to something different..
> I actually though on letting the activate() method receive a Mask value
> as an argument.. like, activate( UInt16 mask ), where mask could be a
> combination of the following: Viewport::ActivateRead,
> Viewport::ActivateWrite or Viewport::ActivateSize ...
>
> The Viewport::activate method coud have the Viewport::ActivateSize as
> default flag mask. And the StereoBufferViewport::activate method could
> have the ActivateSize and ActivateWrite flags as default..
>
> Well, what do you think? I would appreciate any suggestions on this
> topics.. design, method name .. flags name.. anything..
Hm, personally I would rather split it into separate methods, one for
changing
size, one for activate and one for deactivate. They do different things,
so I
think they should be separate. Given that the Read/Draw buffers are
indepepdent
of the size, I think there is little motivation to merge them.
Unless I'm missing something, that is. ;)
Dirk
So, there could be an activateSize() method (only for glViewport)? I could
call it from the activate() method anyway, but someone wishing to change
only the size of it very frequently could call only activateSize().
Hm, just to report, the glViewport is not at the RenderAction (start()
method) anymore, so, someone implementing new viewports should call the
activate() method before the RenderAction apply().
Thanks
Olavo.
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Opensg-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensg-users
