Dirk Reiners wrote: > Hi Patrick, > > Patrick Hartling wrote: >> I have run across a problem building against OpenSG 2 where the code in >> OSGSFieldAdaptor.h does not compile because that file does not include >> OSGFieldTraits.h. I could fix it by including OpenSG/OSGFieldTraits.h in the >> code I am working on (which means changing a lot of files in this case), or >> I could try reordering headers until things compile (again modifying a lot >> of files). However, it seems like the safest option is to modify >> OSGSFieldAdaptor.h to include OSGFieldTraits.h itself. I have made this >> change to OSGSFieldAdaptor.h and run a complete build of Revision 670 of the >> OpenSG 2 SVN trunk. Is there any reason that this change should not be made? > > I can't think of any, feel free to commit it.
I lack commit access, so I cannot commit my change. I have attached the patch, though. > We need to clean up headers at some point anyway, I'm just trying to > think about a way to automate the discovery process (figuring all that > out manually will be painful...). I don't know if this is strictly related to cleaning up the headers, but I have been making some changes today to silence unused variable warnings in some .inl files. Warnings from OpenSG .h and .inl files are plentiful enough that I needed to get the compiler to quiet down so that I could find error messages. I could do some more work on this front and submit that patch if there is interest. -Patrick -- Patrick L. Hartling VP Engineering, Infiscape Corp. http://www.infiscape.com/
Index: Source/Base/Field/OSGSFieldAdaptor.h =================================================================== --- Source/Base/Field/OSGSFieldAdaptor.h (revision 670) +++ Source/Base/Field/OSGSFieldAdaptor.h (working copy) @@ -43,6 +43,7 @@ #endif #include "OSGBaseTypes.h" +#include "OSGFieldTraits.h" OSG_BEGIN_NAMESPACE
signature.asc
Description: OpenPGP digital signature
------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/
_______________________________________________ Opensg-users mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/opensg-users
