Hi, On Mon, 2008-12-22 at 17:44 +0100, Carsten Neumann wrote: > Hi Gerrit, > > > Datum: Mon, 22 Dec 2008 08:40:12 +0800 > > Von: Gerrit Voss <vo...@camtech.ntu.edu.sg> > > > honestly I don't like that to much. > > well, honestly: me neither ;-)
;-) > > Taking it out of the source dir and > > putting it into the module dir is rather confusing. I would prefer > > something like > > > > Source/Base/CMakeLists.txt: > > > > INCLUDE(CMakeLists.libBase.cmake) > > > > and from OpenSG/CMakeLists.txt you can do > > > > ADD_SUBDIRECTORY(Source/Base) > > > > or you glob for them. Unfortunately AFAIK you can't change the cmake > > file name ADD_SUBDIRECTORY is looking for. > > I've done this now, attached patch is against r1644, > it is at about the same level of conversion as the last patch, i.e. it needs > a bit more work before it is ready. looks a lot better to me too ;-). One minor wish though, could we hide the different passes inside a function or macro. Otherwise I'm fine with it. thanks & kind regards, gerrit ------------------------------------------------------------------------------ _______________________________________________ Opensg-users mailing list Opensg-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensg-users
