Hi,
On Fri, 2009-05-08 at 18:11 -0500, Carsten Neumann wrote:
> Hello Gerrit,
>
> Carsten Neumann wrote:
> > Gerrit Voß wrote:
> >> It also forces far to big rebuilds as instead of just rebuilding tests
> >> now a lot more libs will be rebuild because the test dependencies are
> >> taken into account for the lib build too.
> >
> > I'm not sure I understand this part. It has always been the case that if
> > you do a 'make testFoo' it checked if the libs testFoo depends on are
> > up-to-date. What other libs are now rebuilt?
no, if you add an include dir to one of the later libraries all others,
even if only their tests use it, will rebuild as their command line also
change.
> >> Where the test/doc/unittest passes really a the problem even with 2.6.4,
> >> if not why did they got merged in the first place ?.
> >
> > the problem with 2.6.4 is that we visit the directories that contain
> > CMakeLists.Lib.*.txt files in each pass by calling ADD_SUBDIRECTORY(),
> > and multiple calls to ADD_SUBDIR() with the same argument now produce an
> > error (according to the cmake ML this only worked by accident before,
> > since it rewrites files on each call, and now is simply diagnosed [1]).
> > Now, the big advantage of ADD_SUBDIR() over INCLUDE() was that it
> > created a new scope for stuff like INCLUDE_DIRS(), so that we could have
> > different settings for libs and tests.
> > One thing we could do is move the tests to a /Test directory below the
> > one they currently live in. Other ideas?
>
> doh, the easy fix is to just specify a binary dir for all passes
> explicitly on the ADD_SUBDIR() call ;) -- committed as r1895
> Something related, in r1891 I fixed the dependency computation for the
> OpenSG libs during the build and I believe that should make it
> unnecessary to explicitly place CMakeLists.Lib.{OSGBase,OSGSystem}.txt
> at the beginning of the lib config file list, or is there another reason
> to have them there?
>
don't know if your changes catch it, but the initial problem was that we
currently setup the .y and .l things in the setup pass. As these setups
do more modifications than just adding rules, in particular they add an
include dir, we have to guarantee that this is finished before the
generated .cmake file is used. As this only applies for System I went
the lazy way and instead of modifying the .y and .l setup went for the
quick solution to guarantee the order so that OSGBase and OSGSystem are
finished before anything else. So getting rid of it should not be to
difficult.
kind regards,
gerrit
------------------------------------------------------------------------------
The NEW KODAK i700 Series Scanners deliver under ANY circumstances! Your
production scanning environment may not be a perfect world - but thanks to
Kodak, there's a perfect scanner to get the job done! With the NEW KODAK i700
Series Scanner you'll get full speed at 300 dpi even with all image
processing features enabled. http://p.sf.net/sfu/kodak-com
_______________________________________________
Opensg-users mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/opensg-users
