Looks great to me.  Thanks.

-Allen


On Sun, May 2, 2010 at 2:58 PM, Carsten Neumann <carsten_neum...@gmx.net>wrote:

>        Hello Allen,
>
> Allen Bierbaum wrote:
> > The issue is that the tests against the cost variable for degeneracies
> > isn't precise enough for doubles and considers the vectors to be the
> > same even when they are not.
> >
> > I suggest adding 4 or 5 more 9's on the test here to make sure it can
> > work fine with double values.
>
> hm, I don't like that solution much, the value should depend on the type
> used. I've added TypeTraits<T>::getDefaultEps() and used that instead,
> see r2411.
>
>        Cheers,
>                Carsten
>
>
> ------------------------------------------------------------------------------
> _______________________________________________
> Opensg-users mailing list
> Opensg-users@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/opensg-users
>
------------------------------------------------------------------------------
_______________________________________________
Opensg-users mailing list
Opensg-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensg-users

Reply via email to