Hello David, Daniel,
David Kabala wrote:
> ---------- Forwarded message ----------
> From: *Daniel Guilliams* <dani...@iastate.edu <mailto:dani...@iastate.edu>>
> Date: Wed, Jun 9, 2010 at 2:26 PM
> Subject: Re: Fwd: Ship Export
> To: David Kabala <djkab...@gmail.com <mailto:djkab...@gmail.com>>
> Here is the patch and a quick explanation of the error.
>
> Collada <instance_node> patch: This patch fixes an error with
> occurrences <instance_node> in .dae file importing. Pre-patch, whenever
> an <instance_node> was instantiated, the node which the <instance_node>
> was referencing (or instancing, as it were) would not show up in the
> scene. This was because the subtree containing the original geometry
> was being removed from its parent node, and then being placed under the
> instanced node. For the instances after the first, the subtree
> containing the geometry was cloned, so there wasn't any problem. This
> patch ensures that all occurrences of <instance_node> perform a clone
> instead of simply moving the subtree from the original node that the
> <instance_node> is instancing.
thanks for the patch and test file!
I have applied a slightly different version (r2440) that attempts to
avoid cloning the tree if the node does not have a parent yet. It loads
your test file correctly.
On my anim branch on github I've also modified the way instancing
(especially of nodes) works and that also handles the test file
correctly, but it is tricky to move those improvements to the trunk
without dragging in the animation stuff as well.
Cheers,
Carsten
------------------------------------------------------------------------------
ThinkGeek and WIRED's GeekDad team up for the Ultimate
GeekDad Father's Day Giveaway. ONE MASSIVE PRIZE to the
lucky parental unit. See the prize list and enter to win:
http://p.sf.net/sfu/thinkgeek-promo
_______________________________________________
Opensg-users mailing list
Opensg-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensg-users
