Hello Alexander, On 09/24/2012 06:13 PM, Alexander Lang wrote: > thanks for your review and edits, on closer inspection i also noted some > issues in my code.
thanks for the update, I've added those and committed it. > I removed the commented code bits and changed create() to createLocal() in > two occasions (a question here: does it matter? what are the differences > between UnrecPtrs/createLocal() and RecPtrs/create()?). FieldContainer created with createLocal() are not distributed in a cluster, so that's what you want for the stage data. The ref count changes made by UnrecPtr are not recorded in the changelist, so they also are not transmitted. This is can be used as a minor optimization if the pointed to object is ultimately stored in a field - there is not need to duplicate all the ref count increments/decrements on the remote side as long as ultimately a field keeps the object alive there. RecPtr have all ref count changes duplicated, they can be used to keep objects alive on the remote side if only the application refers to them (otherwise, since on the remote side often only a simple render server runs nothing would keep these objects alive). > I also edited the GLSL code in the test app to be compatible to OpenGL > 2.1/GLSL 1.20 instead of 3.30. The changed code is again available at > www.cip.ifi.lmu.de/~langal/osg_depthpeel.zip. I think a sampler2DRect is what you want, that way you don't have to pass in the window dimensions. > The test currently still requires OpenSG to be compiled with > OSG_ENABLE_OGL_VERTEXATTRIB_FUNCS on. My question: could this switch be > enabled by default? hmm, honestly I have no idea. Gerrit? > Concerning documentation I also think that the tutorial at > http://www.opensg.org/wiki/Tutorial could use some update with a new > chapter devoted to the various stages and their usage. agreed ;) > Also the patch could remove the fprintf(stderr, "bp : %d\n", basepoint); > in OSGSimpleGeometry.cpp. yea, looks like those slipped in by accident, removed. Thanks! Cheers, Carsten ------------------------------------------------------------------------------ How fast is your code? 3 out of 4 devs don\\\'t know how their code performs in production. Find out how slow your code is with AppDynamics Lite. http://ad.doubleclick.net/clk;262219672;13503038;z? http://info.appdynamics.com/FreeJavaPerformanceDownload.html _______________________________________________ Opensg-users mailing list Opensg-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensg-users
