Hello all,

On 10/03/2012 06:29 AM, Christoph Fünfzig wrote:
The code in OSBRootElement looks like this
FWARNING(("OSBRootElement::mapPtrField: FieldHandles invalid, "
                            "can not set pointer - target fc [%u] fieldId
[%u] file id [%u] system id [%u]\n",
                            (fc != NULL ? fc->getId() : 0), fieldId,
*idIt, (idMapIt != idMapEnd ? idMapIt->second : 0)));

It outputs the ID of the target FC, but the type names in addition
would be more instructive to the human reader!

agreed, see attached patch; committed.

        Cheers,
                Carsten

diff --git a/Source/System/FileIO/OSB/OSGOSBRootElement.cpp b/Source/System/FileIO/OSB/OSGOSBRootElement.cpp
index bd69708..e1b998e 100644
--- a/Source/System/FileIO/OSB/OSGOSBRootElement.cpp
+++ b/Source/System/FileIO/OSB/OSGOSBRootElement.cpp
@@ -466,7 +466,7 @@ OSBRootElement::mapPtrField(const PtrFieldInfo &ptrField)
             {
                 fc = NULL;
             }
-            
+
             if(pSFHandle != NULL && pSFHandle->isValid())
             {
                 pSFHandle->set(fc);
@@ -478,8 +478,15 @@ OSBRootElement::mapPtrField(const PtrFieldInfo &ptrField)
             else
             {
                 FWARNING(("OSBRootElement::mapPtrField: FieldHandles invalid, "
-                          "can not set pointer - target fc [%u] fieldId [%u] file id [%u] system id [%u]\n",
-                          (fc != NULL ? fc->getId() : 0), fieldId, *idIt, (idMapIt != idMapEnd ? idMapIt->second : 0)));
+                          "can not set pointer - target fc [%u][%s] "
+                          "fieldId [%u][%s] file id [%u] system id [%u]\n",
+                          (fc != NULL ? fc->getId() : 0),
+                          (fc != NULL ? fc->getType().getCName() : ""),
+                          fieldId,
+                          (fc != NULL ?
+                          fc->getType().getFieldDesc(fieldId)->getCName() : ""),
+                          *idIt,
+                          (idMapIt != idMapEnd ? idMapIt->second : 0) ));
             }
         }
     }
------------------------------------------------------------------------------
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
_______________________________________________
Opensg-users mailing list
Opensg-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/opensg-users

Reply via email to