On 02.11.2015 11:22, Johannes wrote: > On 29.10.2015 01:12, Carsten Neumann wrote: >> >> I think for consistency with most of the rest of the >> API (and symmetry with addOverride) it should be subOverride instead of >> removeOverride. > Yes, you are right. > >> Could you also please add a comment to the new bool removeOverride field >> describing what it does. > Yes. > >> I'm wondering if it would be better to have a separate collection of >> chunks to "remove" instead of changing the semantics of the group based >> on a bool flag? But given that this is driven by your needs I don't feel >> strongly one way or the other :) > Personally, I think that it would be a kind of code bloat to introduce > new classes specifically for that matter. > > Below you can find the patch file and the modified source files. > > Thanks for taking your time to look at this issue. > > Best, > Johannes > > > > > ------------------------------------------------------------------------------ > > > > _______________________________________________ > Opensg-users mailing list > Opensg-users@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/opensg-users > ping :-)
------------------------------------------------------------------------------ Presto, an open source distributed SQL query engine for big data, initially developed by Facebook, enables you to easily query your data on Hadoop in a more interactive manner. Teradata is also now providing full enterprise support for Presto. Download a free open source copy now. http://pubads.g.doubleclick.net/gampad/clk?id=250295911&iu=/4140 _______________________________________________ Opensg-users mailing list Opensg-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/opensg-users
