Thanks a lot for your patch. 2014-11-16 9:35 GMT+01:00 Michael Suelmann <[email protected]>:
> I'm affected too. I looked into the code and the cause are the functions > on_txtIn_value_changed and on_txtOut_value_changed which try to sanitize > the start and end times of the clip. > > on_txtIn_value_changed checks if the start time is not bigger than the > end time, but it is called before before the txtOut (end time) is set, > so it always checks agains an end time of 0. This can be fixed with the > patch from Bjorn Hjortsberg which first sets the end time and then the > start time. > > on_txtOut_value_changed checks if the end time is at least as big as the > start time and if the end time is no bigger than the clip length. The > first check doesn't do harm if we change the order of the initializing > as the check is then performed with a start time of 0. The second check > is not valid though: If you slow down the clip you have to enter an end > time according to slowed time which can be larger than the clip length. > And if you want the last frame of a clip to be visible after the clip is > finished, you need a bigger end time than clip length too. > > I attached a patch which includes the patch from Bjorn Hjortsberg to > reorder initialization and additionally removes the bogus check of the > end time against the clip length. > > ** Patch added: "in_time_out_time.patch" > > https://bugs.launchpad.net/openshot/+bug/1198555/+attachment/4261685/+files/in_time_out_time.patch > > -- > You received this bug notification because you are a member of OpenShot > Bugs, which is subscribed to OpenShot Video Editor. > https://bugs.launchpad.net/bugs/1198555 > > Title: > In time in clip properties is not set correct > > Status in OpenShot Video Editor: > New > > Bug description: > Openshot 1.4.3 on Linux Sabayon. > > Under the "length"-tab in clip properties there is a textbox with start > time for the clip, this time is always 0 (or actually -0.01). > The reason for this is that when clip properties dialog is loaded the > txtIn-textbox is set before txtOut-textbox which lead to that local_out is > 0.0 in on_txtIn_value_changed(). The logic: > if local_in >= local_out: > local_in = local_out - 0.01 > self.txtIn.set_text(str(local_in)) > will then set textbox text to -0.01. > > One solution to this is to switch the order for setting txtOut and > txtIn, that is set txtOut before txtIn (in > frmClipProperties::__init__()). > > To manage notifications about this bug go to: > https://bugs.launchpad.net/openshot/+bug/1198555/+subscriptions > > -- > Mailing list: https://launchpad.net/~openshot.bugs > Post to : [email protected] > Unsubscribe : https://launchpad.net/~openshot.bugs > More help : https://help.launchpad.net/ListHelp > -- Olivier Cenwen un elfe sur la banquise/ an elve on the ice Mon blog perso sur le multimédia, Ubuntu, Linux et OpenShot : http://linuxevolution.wordpress.com/ Le forum d'Openshot où vous me trouverez : http://openshotusers.com/ http://openshotusers.com/forum/index.php Nothing is lost until the last second. The family motto : When we want, we can. Astuces, Actualités, Logiciels, bref sur tout ce que je ne fais d'articles dessus Google+ <https://plus.google.com/u/0/111472725110173916234/posts>
-- Mailing list: https://launchpad.net/~openshot.bugs Post to : [email protected] Unsubscribe : https://launchpad.net/~openshot.bugs More help : https://help.launchpad.net/ListHelp
