TJ, I have spent a few hours tonight reviewing all of the changes. I am working through integrating your branch into the trunk, so please don't make any further commits to your branch (for the time being).
Here are my initial findings: 1) I have no problems with the restructuring of folders / files, etc... Nice Job! 2) The biggest issue: the global variables do not fit with the design of OpenShot. In the spirit of keeping everything object oriented, and to fix many issues that global variables create in my local debug environment, I've moved your global PATH variables (and a few folder checking methods) into the project class. I've kept most of your code, I've just moved it around a bit, and made your global vars a part of a class. This allows me to run OpenShot from the /main/openshot/openshot.py file, or from the /main/launcher. Of course, this means I'm having to go touch every file again, but it's not that big of a deal. It will be more flexible this way, while still retaining the effeciancy of only defining these variables 1 time. 3) There were some indention inconsistanceis. I've converted all of the spaces into tabs, to be consistant with the rest of OpenShot 4) There are some PATHs that are being mapped incorrectly, which causes some dialogs to not launch Overall, the new directory structure, renamed files, new info class, new xdg stuff, and most of the changes look good. However, there is still much work to be done, and lots of regression testing I need to do. I also have a few more changes that I need to integrate into the code (some of the newer commits). Give me another day (time permitting), and hopefully I'll be ready to commit these changes to the trunk. Thanks for your help TJ! -Jonathan
_______________________________________________ Mailing list: https://launchpad.net/~openshot.developers Post to : [email protected] Unsubscribe : https://launchpad.net/~openshot.developers More help : https://help.launchpad.net/ListHelp
