Thanks Jonathan - I was treating this as a bit of an experimental branch, so I'll apply all your changes and try and get it tidied up so it is easier to merge/patch from.
I think I lost the icons on the main.glade file - everytime I change something the icons disappear. Cheers, Andy. 2009/9/23 Jonathan Thomas <[email protected]> > Andy, > Just to be clear, the .patch contains more than just changes to the glade > file. There are a few changes to MainGTK.py in there also. > > Thanks, > -Jonathan > > > On Wed, Sep 23, 2009 at 12:14 AM, Jonathan Thomas < > [email protected]> wrote: > >> Andy, this looks like a great start. This is a tricky feature to add, as >> you've discovered. Lots of moving parts to keep in sync. I downloaded the >> branch tonight and did a bit of work on the .glade file, and fixed a few >> scrollbar issues. Please take a look at this .patch. (I'm also attaching >> the .glade file, in case the patch is no good). >> >> I did the following things: >> 1) Replaced the gtkTable in the glade file with some vertical and >> horizontal splitters (much more control over how they fill the screen). No >> more spacing issues. >> 2) Fixed a bug in the scrollbar_scroll methods >> 3) Made it where both the left and right canvases scroll the tracks with >> the scroll wheel (no matter which canvas you are over with the mouse) >> 4) Removed an import to preferences on MainGTK.py (couldn't find the file) >> >> Remaining issues: >> 1) There were many warnings about missing stock icons from some of the >> context menus. I'm not sure if I blew them away, or you did. But you might >> want to just overwrite those parts of the .glade file with the correct XML >> from our trunk. =) >> >> Note: This patch will only work on Andy's branch. >> >> Thanks, >> -Jonathan >> >> On Tue, Sep 22, 2009 at 2:59 PM, Andy Finch < >> [email protected]> wrote: >> >>> I've been working on making the timeline ruler static, so it doesn't >>> scroll up & down with the tracks. I think I've ironed out the last issue, so >>> was wondering if anyone gets any spare time if they could grab a copy of >>> this branch and try it out - it's quite a major change so I'd want another >>> set of eyes to look at it before we decide to commit it. >>> >>> The only issue I can see is when you maximise the application, the gap >>> between the ruler and the first track grows quite a bit. >>> >>> To get the branch: >>> >>> bzr branch lp:~fincha/openshot/static-timeline >>> >>> Cheers, >>> Andy. >>> >>> _______________________________________________ >>> Mailing list: >>> https://launchpad.net/~openshot.developers<https://launchpad.net/%7Eopenshot.developers> >>> Post to : [email protected] >>> Unsubscribe : >>> https://launchpad.net/~openshot.developers<https://launchpad.net/%7Eopenshot.developers> >>> More help : https://help.launchpad.net/ListHelp >>> >>> >> >
_______________________________________________ Mailing list: https://launchpad.net/~openshot.developers Post to : [email protected] Unsubscribe : https://launchpad.net/~openshot.developers More help : https://help.launchpad.net/ListHelp
