No objections here. It is a pity that DotNetZip appears currently unmaintained and I'm not fond of having special
patches but it's not as if these compression formats are evolving and it doesn't sound like a major patch.
One thing to watch out for is that this library is strongly-named. So substituting our own compiled version will
disrupt any third-party DLL that is relying on this strong name (I don't think our DLLs have this active). Any
third-party DLL will either have to recompile against the new Ionic.zip.dll or make sure it doesn't rely on the strong name.
Another small point is to make sure the library is set chmod u+xr in git. This allows it to work on cygwin out of the
box (windows itself and mono don't care about this afaik).
As Nebadon says, if you could make sure we can trace the new DLL back to a specific version of Ionic + patches in
opensim-libs then that would be great.
On 12/02/13 05:06, Nebadon Izumi wrote:
+1, please put code into opensim-libs :)
On Mon, Feb 11, 2013 at 11:45 PM, Diva Canto <[email protected]
<mailto:[email protected]>> wrote:
The version of this lib that we currently have in core has a bug that is
affecting the diva distro:
http://dotnetzip.codeplex.com/__workitem/15236
<http://dotnetzip.codeplex.com/workitem/15236>
The suggested fix actually fixes it.
Unless someone objects, I would like to replace the dll with a new one
compiled by me, with the fix. I don't see a
lot of action on that DotNetZip project.
_________________________________________________
Opensim-dev mailing list
[email protected] <mailto:[email protected]>
https://lists.berlios.de/__mailman/listinfo/opensim-dev
<https://lists.berlios.de/mailman/listinfo/opensim-dev>
--
Michael Emory Cerquoni
_______________________________________________
Opensim-dev mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/opensim-dev
--
Justin Clark-Casey (justincc)
OSVW Consulting
http://justincc.org
http://twitter.com/justincc
_______________________________________________
Opensim-dev mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/opensim-dev
