Im in mels camp on this one.
Trinity Bays On Sat, Apr 19, 2014 at 4:14 AM, Melanie <[email protected]> wrote: > These "other places" are what I'm worried about. There are a lot of them > and each of them would need to have code added. Exception handling code is > one of the worst types of code because the "try" is a scope, so locals > devlared in the try, like bool result = MethodToTry(); will have to be > split up into declaring the bool outside the scope and assigning it inside > - incredibly ugly for code that wants to be reference and teaching code as > well as a functioning system. > > - Melanie > > On 19 Apr 2014, at 08:02, Oren Hurvitz <[email protected]> wrote: > > My fix has two parts. > > The first is that the Store() operation needs to understand failures > correctly. There has been a consensus that it should, so I'll add that to > Git. > > The second is that MakeRequest() should propagate exceptions, instead of > just returning null (which is what it does now). So far there have been 3 > votes for this (me, Mike Chase, and Justin) and 2 against (Melanie, Diva). > That's very close; does anyone else want to make their position known? > > Next, I see that there's confusion in this discussion about what happens > in Store() if MakeRequest() throws an exception. And the answer is, nothing > will be different, because Store() already correctly catches exceptions. > That is precisely how it should work: the low-level communications system > reports when it has failed, and higher levels (that know the business value > of the call) decide how to handle it. However, MakeRequest() is called from > other places as well and they might need to be changed to handle exceptions > better. > > _______________________________________________ > Opensim-dev mailing list > [email protected] > http://opensimulator.org/cgi-bin/mailman/listinfo/opensim-dev > _______________________________________________ > Opensim-dev mailing list > [email protected] > http://opensimulator.org/cgi-bin/mailman/listinfo/opensim-dev >
_______________________________________________ Opensim-dev mailing list [email protected] http://opensimulator.org/cgi-bin/mailman/listinfo/opensim-dev
