Why would it be committer only?
You could certainly use pull requests. Changes get made on a branch and
then a pull request is issues. There can be review comments based on
the pull request. Presumably at some point someone on the core team can
apply the pull request and get the commit into master.
A very common workflow in use all over today. I think it would be
beneficial to adopt it. More learning opportunities and chances for
comment as things go into MASTER. But its extra process and the core
team or a core member would have to own accepting changes after the
review period completes.
Mike
On 01/10/2015 06:39 AM, Ai Austin wrote:
One thing we do not seem to have in the OpenSim setup for reporting
issues (Mantis), discussing proposed changes (dev mailing list), etc.
is a way to be able to give quick feedback on OpenSim dev master
commits where we spot simple things - such as typos or missing or
inconsistent config files.
Of course Mantis is there for substantive issues or bugs. But after a
commit, as I am tracking changes in .ini files especially in my
testing, I sometimes spot issues where Robust.HG.ini.example gets
missed out when Robust.ini.example changes. And even spelling and
typos. I do consider if its substantive enough to post a Mantis issue,
but if its a tiny thing, I may send a short e-mail to the committer.
But, I wonder if there is a better general mechanism, perhaps by
allowing comments on a GIThub commit that the committer only receives?
_______________________________________________
Opensim-dev mailing list
[email protected]
http://opensimulator.org/cgi-bin/mailman/listinfo/opensim-dev
_______________________________________________
Opensim-dev mailing list
[email protected]
http://opensimulator.org/cgi-bin/mailman/listinfo/opensim-dev
