Hi Roel, The change in r1597 was only supposed to abstract the cache refresh code into a separate function, not change anything else, so the change to the address size in the second call was incorrect. Please go ahead with the update.
Regards, Richard -----Original Message----- From: Roel van de Kraats [mailto:rkra...@dds.nl] Sent: 25 May 2011 11:34 To: 'openslp-devel@lists.sourceforge.net' Subject: [Openslp-devel] Bug in libslp_knownda.c Dear all, It seems that libslp_knownda.c has a bug on line 716 (see http://openslp.svn.sourceforge.net/viewvc/openslp/trunk/openslp/libslp/libsl p_knownda.c?view=markup&pathrev=1672), because sizeof(struct in_addr) is too small to copy the whole address. This causes 'slptool findsrvtypes' to fail in case another host acts as DA. This was introduced in r1597 (see http://openslp.svn.sourceforge.net/viewvc/openslp?view=revision&revision=159 7). I guess it is safe to replace 'sizeof (struct in_addr)' with 'sizeof(struct sockaddr_storage)', but I'm not sure. If anyone can confirm this, I'll commit the fix. BR, Roel ---------------------------------------------------------------------------- -- vRanger cuts backup time in half-while increasing security. With the market-leading solution for virtual backup and recovery, you get blazing-fast, flexible, and affordable data protection. Download your free trial now. http://p.sf.net/sfu/quest-d2dcopy1 _______________________________________________ Openslp-devel mailing list Openslp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openslp-devel This email, including any attachment, is a confidential communication intended solely for the use of the individual or entity to whom it is addressed. It contains information which is private and may be proprietary or covered by legal professional privilege. If you have received this email in error, please notify the sender upon receipt, and immediately delete it from your system. Anything contained in this email that is not connected with the businesses of this company is neither endorsed by nor is the liability of this company. Whilst we have taken reasonable precautions to ensure that any attachment to this email has been swept for viruses, we cannot accept liability for any damage sustained as a result of software viruses, and would advise that you carry out your own virus checks before opening any attachment. ------------------------------------------------------------------------------ vRanger cuts backup time in half-while increasing security. With the market-leading solution for virtual backup and recovery, you get blazing-fast, flexible, and affordable data protection. Download your free trial now. http://p.sf.net/sfu/quest-d2dcopy1 _______________________________________________ Openslp-devel mailing list Openslp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openslp-devel
