I'm back from vacation, now, so my responses can be a bit more timely. :)

I haven't attempted to run this code. But I did look over the code I had an
issue with earlier, and the key is that  SLPDDatabaseReg in slpd_database.c
uses a local variable named 'ifaces', and doesn't seem to properly
initialize that structure.  It will only show up when using IPv6.  When I
did the original code review, I grepped for all usages of the SLPIfaceInfo
class, and this was the only red flag I saw.  Sorry if I wasn't more
explicit earlier.

--Nick

On Thu, Sep 27, 2012 at 12:28 PM, David Stevens <dlstev...@us.ibm.com>wrote:

> nwagner...@gmail.com wrote on 09/27/2012 12:03:33 PM:
>
> > I'm away from my devel machine right now, but from what I remember,
> > you changed the slpifaces structure from having two static arrays of
> > SLP_MAX_IFACES to two pointers.  It appeared to me at the time that
> > SLPDDatabaseReg wasn't allocating memory for those pointers when
> > initializing the slpifaces structure.
>
>         This is done in SLPDIncomingInit() and in SLPDIncomingReinit(),
> which is called after SLPDPropertyInit() so they have the current
> config file value for slp_max_ifaces before they are allocated. And
> the old ones, if there, are freed in SLPDIncomingReinit() before
> allocating
> the new ones.
>         Because the test programs don't use these, they have their own
> allocations in the main programs. (e.g., main() in slp_iface.c)
>         Did you see a problem while running it, or was it something
> you were concerned about from code browsing? I could declare them as
> static,
> external or just explicitly initialize the pointers to NULL which would
> fault on any indirection before initialization, but I believe I've
> covered all the cases in the original.
>
>                                                         +-DLS
>
>
>
> ------------------------------------------------------------------------------
> Everyone hates slow websites. So do we.
> Make your web apps faster with AppDynamics
> Download AppDynamics Lite for free today:
> http://ad.doubleclick.net/clk;258768047;13503038;j?
> http://info.appdynamics.com/FreeJavaPerformanceDownload.html
> _______________________________________________
> Openslp-devel mailing list
> Openslp-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/openslp-devel
>
------------------------------------------------------------------------------
Got visibility?
Most devs has no idea what their production app looks like.
Find out how fast your code is with AppDynamics Lite.
http://ad.doubleclick.net/clk;262219671;13503038;y?
http://info.appdynamics.com/FreeJavaPerformanceDownload.html
_______________________________________________
Openslp-devel mailing list
Openslp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openslp-devel

Reply via email to