Quoth Roel van de Kraats: > I looked at it very briefly and it seems to me that it is not quite > 'finished' yet:
That's true, as noted in the patch; it was just enough to get my particular scenario behaving itself, but could probably use some better tidy-ups from someone who knows what they're doing. :) > * I guess that SLPDIncomingDeinit() will close all open connections, > which should only be done for 'disappearing' network interfaces. Yeah. I was envisaging a more proper fix would be to implement a "Reinit" method (similar to the property system) which closed all listening ports without affecting the accepted sockets, or (to minimise disruption) figured out the difference between old and new ports and only closed those which were no longer valid. I could probably manage a modification to the patch to do the former, but the latter is beyond my current knowledge of the code. It does strike me as slightly weird that the listening and accepted sockets are kept in the same list at the moment. How much of a benefit the latter over the former might be depends on how much of a problem the listening sockets being temporarily unresponsive would be. On my system the HUP is sufficiently fast that they're only down very briefly, such that anything which does retries (which is most clients, I thought) wouldn't notice at all, especially given that the HUP trigger should be very rare (usually only during machine startup or following a network outage or physical modification to the network connections). (I haven't done any testing with DAs, though.) > * The net.slp.interfaces property seems to behave somewhat strange; it > can be used to specify which interfaces should be used, but afterwards > it will indicate the actually used interfaces. This will work fine for > the current 'one time configure' mechanism, but will probably have to be > fixed for a more 'dynamic' mechanism. Doesn't the reinit of the property file sort that out? ------------------------------------------------------------------------------ Don't let slow site performance ruin your business. Deploy New Relic APM Deploy New Relic app performance management and know exactly what is happening inside your Ruby, Python, PHP, Java, and .NET app Try New Relic at no cost today and get our sweet Data Nerd shirt too! http://p.sf.net/sfu/newrelic-dev2dev _______________________________________________ Openslp-devel mailing list Openslp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openslp-devel
