Hi John, Just noticed a minor bug (sorry, it was in my original patch):
In slpd/slp_win32.c line 135 (InterfaceMonitorInit): - if (!(self->pNotifyIpInterfaceChange && self->pNotifyIpInterfaceChange)) + if (!(self->pNotifyIpInterfaceChange && self->pCancelMibChangeNotify2)) It won't actually cause any problems in practice, as one of these won't exist without the other. But this is more correct. Also the comment at line 146 (regarding casting) can be removed; this was from an older version of the code, which was solved differently in the final patch (see line 77). Regards, Gavin > -----Original Message----- > From: John Calcote [mailto:john.calc...@gmail.com] > Sent: Thursday, 29 November 2012 08:50 > To: 'Gavin Lambert'; openslp-devel@lists.sourceforge.net > Subject: RE: [Openslp-devel] [PATCHv2] semi-automatically refresh > listening interfaces > > Hi Gavin, > > Your dynamic ifc reinit patch has been incorporated into the repository. > Thanks for your efforts. > > Regards, > John > > > -----Original Message----- > > From: Gavin Lambert [mailto:gav...@compacsort.com] > > Sent: Thursday, October 25, 2012 9:32 PM > > To: openslp-devel@lists.sourceforge.net > > Subject: [Openslp-devel] [PATCHv2] semi-automatically refresh > > listening interfaces > > > > I've attached a variation of the previous patch (still against the 2.0 > beta > > 2 tarball) which handles the reinit slightly differently from the > original. > > > > This one will start listening on any newly discovered (or configured) > > interfaces, without closing or stopping any previously opened incoming > > sockets. > > > > The advantage over the previous patch is that it will cause less > disruption to > > ongoing communications, particularly if only a secondary interface is > > changing. The disadvantage is that if the service is left running for > > a > long time > > on a network that keeps assigning it different addresses (presumably > > via a DHCP server with a bad memory) then it will gradually eat up > > more and more resources, and probably eventually fail. (I'm not sure > > which tradeoff is > better > > overall.) > > > > A suggested improvement (which again I'm not quite familiar enough > > with the code to do at this point) would be to track which sockets are > associated > > with a particular interface and close them if their interface is not > > still > present > > during the reinit. > > > > Note that for code simplicity it's currently assuming that if the TCP > listen > > socket exists then all the other related sockets are still ok too. ------------------------------------------------------------------------------ Everyone hates slow websites. So do we. Make your web apps faster with AppDynamics Download AppDynamics Lite for free today: http://p.sf.net/sfu/appdyn_d2d_feb _______________________________________________ Openslp-devel mailing list Openslp-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openslp-devel
