Hello again,
And there's another minor issue - redundant check for "attrlist == 0"
in SLPDRegFileReadSrvReg() (openslp-2.0.0/slpd/slpd_regfile.c).
The condition on line 347 can't be TRUE, because in the previous
block of code "attrlist" variable is set to non NULL value
(or the function exits in case of insufficient memory) - in the TRUE
branch see line 325, in the FALSE branch see line 343.
Attached patch removes the redundant check and non reachable
code inside the block.
Best regards,
Vitezslav Crhonek
--- openslp-2.0.0/slpd/slpd_regfile.c.orig 2014-08-05 13:38:45.671948382 +0200
+++ openslp-2.0.0/slpd/slpd_regfile.c 2014-08-05 13:38:56.503011806 +0200
@@ -344,12 +344,6 @@
strcat(attrlist, ",");
}
- if (attrlist == 0)
- {
- result = SLP_ERROR_INTERNAL_ERROR;
- goto CLEANUP;
- }
-
/* we need special case for keywords (why do we need these)
they seem like a waste of code. Why not just use booleans */
if (strchr(slider1, '='))
------------------------------------------------------------------------------
Infragistics Professional
Build stunning WinForms apps today!
Reboot your WinForms applications with our WinForms controls.
Build a bridge from your legacy apps to the future.
http://pubads.g.doubleclick.net/gampad/clk?id=153845071&iu=/4140/ostg.clktrk
_______________________________________________
Openslp-devel mailing list
Openslp-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openslp-devel
