Ceri Davies wrote:
> On Thu, Sep 18, 2008 at 05:11:12PM +0800, Frank Che wrote:
>
>> I'm sponsoring this case for Ye Li. This case is to make a minor update
>> to the Amaranth project to support PCI device detection on FreeBSD. It
>> requests a minor release binding to the Sun Device Detection Tool product.
>>
>> I have marked it as "closed approved automatic" since the change is
>> straightforward and the interface is clear.
>>
>
>
>
>> Interfaces Imported:
>>
>> ------------------------------------------------------------------
>> | OS Type | Interface | Purpose |
>> ------------------------------------------------------------------
>> | FreeBSD | /dev/pci | Scan file /dev/pci to read PCI |
>> | | PCIOCREAD | device data |
>> ------------------------------------------------------------------
>>
>
> FWIW, I think you'll need to use PCIOGETCONF as well.
>
I realize that FreeBSD doesn't use the same interface stability levels,
but are the PCI ioctls morally "public" (preferably documented in man
page)? (I.e. I want to make sure that we aren't using some kind of
internal-use-only API that could change at the drop of the hat. I don't
think we are, but I'd like it to be explicit in the case materials.
Assuming no surprises there, then I'd agree that the case falls into the
automatic-approval bucket.
-- Garrett
> Ceri
>
