Kais Belgaied wrote:
>
>> Problem
>> -------
>>
>> Various network drivers are inconsistent in their handling of logging of
>> link messages. One of the more annoying things that some drivers do is
>> flood the logs with link down messages (usually once every 10sec or
>> so) when
>> trying to transmit packets out the link.
>>
>>
> The root cause of the problem as you describe seems to be the fact
> that the stack above kept
> submitting the packets to a link that is known to be down, causing the
> flood of syslogs.
> Somehow the event of link-down was not generated, lost during the
> notification, or mishandled.
> That is a bug to be fixed between the stack and the specific drivers
> you observed the misbehavior
> on. The bug is probably below the radar screen for ARC.
>
> Now, back the the symptoms (scope of this case): Each futile
> submission of a packet to be
> transmitted on a link down indicates a problem worth paying attention
> to. It could be
> uncovering a bug such as the above, or it could be transient race. I
> don't believe it
> is a bad practice from driver writers to adopt a defensive approach
> and log
> an error on every occurrence of the offense.
Yikes! That's a bad idea, if you mean doing it in syslog.
Of course, we _do_ log (collect) this information in the carrier_errors
kstats. Just like we do for all other network related errors.
-- Garrett
>
> Kais
>
>> Further, the detailed contents for link status changes are not
>> consistent
>> from one driver to another.
>>
>> Notably, the WIFI drivers generally do not do this.
>>
>>
>>
>
>
