On Fri, Jan 16, 2009 at 12:33:32AM +0800, Xiang Samuel Zhou wrote: > > ----- Original Message ----- > From: James Carlson <James.D.Carlson at Sun.COM> > Date: Thursday, January 15, 2009 11:33 pm > Subject: Re: iftop [PSARC/2009/018 FastTrack timeout 01/20/2009] > To: Xiang Samuel Zhou <Xiang.Zhou at Sun.COM> > Cc: Edward Pilatowicz <Edward.Pilatowicz at Sun.COM>, PSARC-ext at sun.com, > Jim Walker <James.Walker at Sun.COM> > > > Xiang Samuel Zhou writes: > > > ----- Original Message ----- > > > From: James Carlson <James.D.Carlson at Sun.COM> > > > > How does it open DLPI devices? > > > It first use "open" system call to open something like /dev/bge, > > then send strbuf containing DL_ATTACH_REQ to the opened STREAMS. It > > uses dlpi device to get the mac address. > > > > If I'm reading that correctly, it doesn't even support DLPI Style 1. > > I'm hoping that's wrong, based on the description below, because it'd > > be a show-stopper of a bug. > iftop ONLY use these codes to get the mac address. For other operations on > interface, it uses functions in libpcap. > I tried to remove the codes to get mac address. it works ok in global zone > and non-global exclusive zone. Further, if I remove all the definations in > dlpi.h and do not include dlpi.h in source code, the compiled binary works > good for exclusive zone and vanity naming. >
this is really good news. if at all possible, it'd be great if you could include these changes in your integrated version of itop and try to contribute those changes back to the community. regardless of if you include these changes, i'd like you to update the man pages delivered with iftop to document any limitations wrt zones. thanks ed