Hi, Darren J Moffat p??e v st 02. 09. 2009 v 13:58 +0100: > Is it safe to assume that this case will update all of the ON and other > Solaris consolidations that have code that uses lbolt/lbolt64 ? > > In the ZFS kernel module alone there are over 30 references to > lbolt/lblot64. > > Was any consideration given to providing something like this: > > #define lbolt ddi_get_lbolt() > #define lbolt64 ddi_get_lbolt64() > > The main reason for suggesting is based on a quick glance of where ZFS > uses lbolt and lbolt64 today those new function calls are going to cause > some ugly cstyle issues in a few places. >
Is it good idea to use macro just to make C-style test happy? Isn't it better to not use such "macro hack", make the code "ugly" and fill new CR per case asking to do source code refactorization? Best regards, Milan
