I'm sponsoring this automatic-approved self review case for Marcel
Telka (RPE).

This case corrects an obvious oversight (missing display of
'forcedirectio' mount flag) in the output of nfsstat(1m) and updates
the corresponding man page.

I believe this case qualifies for self-review, but if anyone disagrees,
let me know and I'll promote it to a fast track.


Template Version: @(#)sac_nextcase 1.68 02/23/09 SMI
This information is Copyright 2009 Sun Microsystems
1. Introduction
    1.1. Project/Component Working Name:
         forcedirectio mount flag in nfsstat
    1.2. Name of Document Author/Supplier:
         Author:  Marcel Telka
    1.3  Date of This Document:
        27 October, 2009
4. Technical Description

 The nfsstat(1m) command has an option (-m) which displays statistics
 for each NFS mounted file system.  This option also displays the mount
 flags for each NFS mounted file system; however, there is one existing
 mount flag that is missing from the display:  forcedirectio

 Support for the forcedirectio mount option was added to the Solaris
 NFS client together with directio(3C) capability as part of the fix
 for CR 4190364 (Solaris 8).  The 'forcedirectio' mount option is
 currently documented in mount_nfs(1M) man page. It was integrated into
 the man page in Solaris 9 by CR 4521941.

 During the development mentioned above, the nfsstat utility was not
 updated to display the forcedirectio mount flag when run with the -m
 option.  The lack of the forcedirectio flag in the 'nfsstat -m' output
 can cause confusion for users.

 This case corrects that oversight by adding support for the
 forcedirectio mount flag to the 'nfsstat -m' output.  This change will
 be documented in nfsstat(1M) man page (see below).

 For example, given the following NFS file system:

   # mount |grep test
   /tmp/test on snvx.czech:/builds 
remote/read/write/setuid/devices/forcedirectio/xattr/dev=6100005 on Mon Oct  5 
08:48:09 2009

 The current 'nfsstat' displays the following (note the lack of the
 'forcedirectio' flag):

   # nfsstat -m /tmp/test
   /tmp/test from snvx.czech:/builds
    Flags:         
vers=4,proto=tcp,sec=sys,hard,intr,link,symlink,acl,rsize=1048576,wsize=1048576,retrans=5,timeo=600
    Attr cache:    acregmin=3,acregmax=60,acdirmin=30,acdirmax=60

 With the proposed change, the 'nfsstat' command would now include the
 'forcedirectio' mount flag:

   # nfsstat -m /tmp/test                                      
   /tmp/test from snvx.czech:/builds
    Flags:         
vers=4,proto=tcp,sec=sys,hard,intr,link,symlink,acl,forcedirectio,rsize=1048576,wsize=1048576,retrans=5,timeo=600
    Attr cache:    acregmin=3,acregmax=60,acdirmin=30,acdirmax=60


 This case also includes an update to the nfsstat(1m) man page which
 has been pre-approved by Terry Gibson.  Terry is the RE for the
 associated man page CR (6888023: nfsstat: "forcedirectio" mount flag
 needs to be documented)

--------------------------------8<--------------------------------------
     The -m option includes information about mount flags set  by
     mount options, mount flags internal to the system, and other
     mount information. See mount_nfs(1M).

     The following mount flags are set by mount options:

     forcedirectio                                                  |
                                                                    |
         Data transferred directly  between  client  and  server,   |
         with no buffering on client.                               |

     grpid

         System V group id inheritance.
--------------------------------8<--------------------------------------

6. Resources and Schedule
    6.4. Steering Committee requested information
        6.4.1. Consolidation C-team Name:
                ON
    6.5. ARC review type: Automatic
    6.6. ARC Exposure: open

Reply via email to