On 04/ 6/10 02:07 AM, Ramshankar wrote:
...
* mac_tx:
mac_tx function (and mac_tx_cookie_t datatype) seems to be missing here.
* dls_mgmt_get_linkid:
vnic_modify_addr() takes a datalink_id_t, this assumes we've created the
VNIC. But our implementation should also work for existing VNICs that a
user can provide to VBox. In which case we'd do a mac_open_by_linkname()
and mac_client_open() which would give us the mac_handle_t and
mac_client_handle_t but not the datalink_id_t. I use
dls_mgmt_get_linkid() to get a datalink_id_t so we can modify the MAC
address of the user-created VNIC.
* mac_unicast_primary_get:
I currently use mac_unicast_primary_get() function to obtain the
currently set MAC address for the VNIC. It would be good if this
function were exported too.
Thanks. We missed these by oversight in our earlier draft.
I am updating the contract with these routines. I will send
out another email for the approval of the updated contract.
Since you've provided separate resource setter/getter functions I guess
we would not ever need a mac_resource_handle_t type, so that's fine.
Yes. That was the intent.
-Krishna
_______________________________________________
opensolaris-arc mailing list
[email protected]
