On 04/ 7/10 08:36 AM, Sebastien Roy wrote:
On 04/ 5/10 02:47 PM, Krishna Yenduri wrote:
It was pointed out to me that this needs to be a fast track since
there is a contract. So, I am making this a fast track case
with the timer set to 4/9/2010.
...
    Header files:
<sys/mac.h>            Consolidation Private
<sys/mac_client.h>        Consolidation Private
<sys/vnic_mgmt.h>        Consolidation Private
<sys/dls.h>            Consolidation Private

The latter three header files are not currently included in any package. I assume that this case delivers these header files as part of some package, presumably pkg:/system/header.(?)

 Yes. They are delivered in pkg/manifests/system-header.mf.

I am generally concerned about the viability of long term use of these contracted interfaces by another consolidation given that the interfaces are not centralized in any part of the ON source (there's no easy way to place a big warning in the code concerning their consumption by another consolidation), and that these interfaces have recently undergone numerous and drastic changes. Assuming that interfaces remain volatile, this could lead to either unintentional breakage of VirtualBox, or complex version dependencies between VirtualBox and the underlying host OS. This is less of a concern if the interfaces contracted have sedimented somewhat and are more stable than they have been in the recent past.

 Agreed on the concern.
 It is for this reason that only a small subset of the interfaces in these
 header files are part of the contract. Also, we added new interfaces
 like mac_client_set_maxbw etc. to avoid exposing less stable (project
 private) interfaces.

This could be mitigated in a number of ways in the longer term. Committing to a Public MAC client API and VNIC API would be one solution. Another might be to integrate the Solaris kernel specific portion of VirtualBox into ON. Has either project team considered such options?

 The longer term solution is a public MAC client API. But, we would like
 to get more experience with clients before making them public.

Thanks,
-Krishna
_______________________________________________
opensolaris-arc mailing list
[email protected]

Reply via email to