On 04/ 7/10 07:56 PM, Mike Oliver wrote:
On 04/07/10 13:38, Brian Cameron wrote:
Garrett/Mike/Albert:
I have attached an updated 1-pager and also updated the 1-pager in the
case directory. I have also attached a new patch which implements the
following changes for review:
This resolves my concerns about processes running as root inadvertently
doing bad things or being tricked into doing bad things.
It's strange that the Xsession logic respects $AUDIODEV but the
PostSession logic does not. That seems unlikely to produce the correct
results if $AUDIODEV is ever set to something other than /dev/audio. Of
course it's not easy to get hold of the session's $AUDIODEV in the
PostSession context. You could do something like iterate over all of
the stored audio setting files for this machine, but I wonder whether
this is just more trouble than it's worth for the intended use case and
you might reasonably just wire both scripts to operate on /dev/audio.
(Subject to the check that that device is owned by this session's user,
of course.) I don't feel strongly either way; my main concern was the
running-as-root issue, and that's been addressed.
Mike.
The better solution long term, involves the use of device allocation
framework. For that framework, we can always do the "right" thing since
it can operate with user context.
- Garrett
_______________________________________________
opensolaris-arc mailing list
[email protected]
