+1.
I always felt the interfaces were not really appropriate for generic
drivers to use.
- Garrett
On 05/13/10 03:19 PM, Govinda Tatti wrote:
I'm sponsoring the following fasttrack for Evan Yan. The timer is
set to expire on 05/20/2010.
- Govinda
Template Version: @(#)sac_nextcase 1.70 03/30/10 SMI
This information is Copyright (c) 2010, Oracle and/or its affiliates.
All rights reserved.
1. Introduction
1.1. Project/Component Working Name:
Renaming interrupt affinity interfaces
1.2. Name of Document Author/Supplier:
Author: Evan Yan
1.3 Date of This Document:
13 May, 2010
4. Technical Description
4. Technical Description:
4.1. Project Summary:
This proposal is to rename the interrupt affinity interfaces
introduced by PSARC/2009/340, and move them into some internal
or platform specific files.
Currently, the ddi_intr_get/set_target() interfaces are project
private ones, and are restricted just to Crossbow framework.
These interfaces will continue to be restricted in long-term just
to IO frameworks such as Crossbow, NUMA etc and there is no plan
to extend them to any DDI complaint drivers.
This changes are expected to be backported to S10 after the
changes of PSARC/2009/340 are backported, so micro/patch
binding is requested.
4.2. Project Description:
Rename the ddi_intr_get/set_affinity() interfaces to the
following interfaces.
/*
* Get/Set interrupt affinity functions
*/
int get_intr_affinity(ddi_intr_handle_t h, processorid_t *pid_p);
int set_intr_affinity(ddi_intr_handle_t h, processorid_t pid);
And move the interface declarations and implementations from
ddi_intr.[ch] to ddi_intr_impl.[ch].
The following type definition in ddi_intr.h will be removed.
typedef processorid_t ddi_intr_target_t;
Accordingly, the definition of the member ih_target of
ddi_intr_handle_impl_t will be modified from
ddi_intr_target_t ih_target;
to
processorid_t ih_target;
The flag DDI_INTR_FLAG_RETARGETABLE will also be removed, and
ddi_intr_get_cap() will not return this flag any more.
The renamed interface set_intr_affinity() will still be limited
to MSI-X interrupts. It will return DDI_EINVAL directly for INTx
and MSI interrupts.
The ddi_intr_set_affinity() interface are currently used by
crossbow in mac_datapath_setup.c, which will also be updated
to call the renamed interfaces instead.
4.3. Bug/RFE Number(s):
6948283 Renaming of existing ddi interrupt re-target interfaces
4.4. Interfaces:
Interface Stability Comments
----------------------------+---------------+--------------------------
ddi_intr_target_t Project Removed
Private
DDI_INTR_FLAG_RETARGETABLE Project Removed
Private
get_intr_affinity Project Renamed from
Private ddi_intr_get_affinity
set_intr_affinity Project Renamed from
Private ddi_intr_set_affinity
4.5. Reference:
PSARC/2009/340 Interrupt affinity interfaces and PCITool
enhancements
6. Resources and Schedule
6.4. Steering Committee requested information
6.4.1. Consolidation C-team Name:
ON
6.5. ARC review type: FastTrack
6.6. ARC Exposure: open
_______________________________________________
opensolaris-arc mailing list
[email protected]
