On Wed, May 26, 2010 at 12:47:48PM -0700, Garrett D'Amore wrote: > On 5/26/2010 12:25 PM, Nicolas Williams wrote: > >On Wed, May 26, 2010 at 11:41:51AM -0700, Garrett D'Amore wrote: > >>Also, your stability levels need to be modernized. We don't use > >>Evolving and Unstable anymore.. Perhaps you mean Uncommitted and > >>Volatile? > >DTrace sticks to the old taxonomy. > > Oh, I didn't realize. Have you reviewed the rest of the case? This > seems to be part of your area of expertise?
Yes, I've reviewed this, twice :) Once in a kerberos list and once on dtrace-discuss. IIRC Adam Leventhal also reviewed it. The i-team was quite responsive to review comments and all necessary changes have been made. IMO this is a very well designed provider and I'm quite happy with it. If anything it doesn't go far enough (I'd like to see USDT probes for the KDB), but the answer to my prodding on that score has been "not this case", which is more than fair enough. Nico -- _______________________________________________ opensolaris-arc mailing list [email protected]
