Roland Mainz wrote:
Bonnie Corwin wrote:
[EMAIL PROTECTED] wrote:
[snip]
FYI, I think part of the confusion in this discussions stems from
decisions that have previously been made within Sun about adding
copyrights and updating the year in a copyright. To keep things
completely simple wrt to process instructions, 'significant' changes are
defined as changes that result in a change to the object code and
changes to comments that are significant enough to be considered
documentation.
Problem is that the added |#include| is AFAIK a border case... the
change itself to the source file is IMO not significant but it includes
a header containing a fixed list of builtin commands (defined by PSARC
2006/550) which are enabled by default which is significant. The idea of
using an |#include|-statement+seperate header (instead of adding the
code directly) was do avoid the need to add something like CDDL and/or a
copyright to the ksh93 sources which would bloat the patch significantly
(e.g. I am seeing this from the technical viewpoint...).
Anyway...
... Glenn added a hook in the ksh93 code to avoid any patches which
means we do not hit this issue for this round (which means we do not
need the *.diff files in this case (and more or less forward that
"fight" to the next case where it may be needed...)).
Bottom line - the project members should make a call.
Do you mean "phone call" ?
Hi Roland,
No, I mean that you and April should decide what to do and use your
judgement.
From the thread, it doesn't seem it's "significant" enough from the
perspective of the ksh93 project for a Sun copyright to be added. And
that's ok.
Re: adding the CDDL. As Roland notes, the outbound OSR allows us to
contribute OpenSolaris code to the ksh93 project using the CPL. No need
to put the CDDL on anything.
Ok... what about adding the "Sun copyright" ... can that be avoided by
using the "OSR" ?
The OSR doesn't address this question. It just gives permission for us
to give OpenSolaris code to ksh93 using the CPL.
As you write new code, you and April can make the judgement call about
adding a Sun copyright as noted above. We have a stricter 'rule' inside
mostly just to keep the process simple. When working with a third-party
project, like ksh93, we want to do what's reasonable for that project.
So for changes like this, either choice is acceptable. FYI, I know Sun
engineers who participate in other projects and don't add Sun copyrights
to everything they contribute - they use their judgement based on the
project and its community and what they contribute.
Thanks.
Bonnie
Sorry for the delay in responding - hope this helps a little.
Thanks for the answers... :-)
----
Bye,
Roland
_______________________________________________
opensolaris-code mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/opensolaris-code
