Greetings,

For a lint warning such as the following regarding fclose:

warning: function returns value which is always ignored: fclose
(E_FUNC_RET_ALWAYS_IGNOR2)

..where the code is something like:

fclose(fp);

I have seen two "solutions" to this, one which strikes me as the
"quick solution":

http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/cmd/fs.d/ufs/repquota/repquota.c#197
    197                 (void) fclose(vfstab);

...and one which seems a bit drawn out, but more like the "right" solution:
http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/cmd/devfsadm/devfsadm.c#5879
   5879         if (fclose(fp) == EOF) {
   5880                 err_print(FCLOSE_FAILED, file, strerror(errno));
   5881         }

http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/cmd/devfsadm/message.h#124
    124 #define FCLOSE_FAILED gettext("fclose failed: %s: %s\n")

What is the "preferred" solution?

Cheers,
-- 
Shawn Walker, Software and Systems Analyst
[EMAIL PROTECTED] - http://binarycrusader.blogspot.com/

"Beware of bugs in the above code; I have only proved it correct, not
tried it. " --Donald Knuth
_______________________________________________
opensolaris-code mailing list
opensolaris-code@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/opensolaris-code

Reply via email to