Peter Memishian writes:
> 
>  > usr/src/uts/common/os/swapgeneric.c includes sys/conf.h twice
>  > usr/src/uts/common/os/fork.c includes sys/class.h twice
>  > 
>  > Directly and not conditional, there are many of those double includes 
> around.
>  > For me it makes no sense and the second include should be removed.
> 
> Yes, those cases should be cleaned up.

Those look like classic merge errors to me.

I'm surprised nobody's mentioned "dmake LINTFLAGS=-axsNlevel=2 lint"
-- this will give you a lot more information about unused header
files.  I always make at least one pass like that before putting back
changes to make sure that I don't have unneeded junk in the source
file.

-- 
James Carlson, Solaris Networking              <[EMAIL PROTECTED]>
Sun Microsystems / 35 Network Drive        71.232W   Vox +1 781 442 2084
MS UBUR02-212 / Burlington MA 01803-2757   42.496N   Fax +1 781 442 1677
_______________________________________________
opensolaris-code mailing list
[email protected]
http://mail.opensolaris.org/mailman/listinfo/opensolaris-code

Reply via email to