Hi, I'm currently working on a fix for bug 6691168 (allow for complex port list specification in nc) and I would like to ask if some of you guys can do a code review of my changes. Its a sponsored CR.
Here is the link to the entry in the bug database http://bugs.opensolaris.org/bugdatabase/view_bug.do?bug_id=6691168 Here is a link to my webrev directory containing the changes http://cr.opensolaris.org/~erisch/nc/ The fix includes a routine which allows to give a list of ports and portranges to nc in the the following format: 1,2-5,8,22-25,12,13. So far only one port xor one portrange was allowed. Now any combination is possible unless you exceed 65536 ports. The fix incorporates a function called strsep() which is about to get in libc in the future but is not available so far (see CR6487100 & 4383867). So don't wonder about the implementation of strsep() inside the netcat.c. Any comments and suggestions are appreciated. Thanks Erik _______________________________________________ opensolaris-code mailing list [email protected] http://mail.opensolaris.org/mailman/listinfo/opensolaris-code
