Darren J Moffat wrote:
Giuliano Santorelli wrote:
Hi,
I need code review for bug 6254183:
http://bugs.opensolaris.org/view_bug.do?bug_id=6254183
Synopsis: encrypt(1) should support blowfish
The code is posted here: http://cr.opensolaris.org/~mao/bug-6254183
...
DJM-0a you can't just add a #define for CKM_BLOWFISH_CBC_PAD to
pkcs11t.h, those defines are controlled by the RSA PKCS#11 working group.
We also have a "policy" in the crypto group that we NEVER ever modify
that file, we only ever bring in complete new versions of it from the
RSA Cryptoki working group site.
This is fundamental to this been acceptable and until the RSA PKCS#11
working group assigns a mech number for CKM_BLOWFISH_CBC_PAD we can't
do it that way. What can be done though is we can add a vendor defined
mechanism (those with mech numbers above 0x80000000) but that must
get added to cryptoki.h not any of the pkcs11?.h files.
Yes. The simplest fix is to make this a vendor defined mechanism.
May I suggest the value, 0x83797601 - hex for SOL1.
-Krishna
_______________________________________________
opensolaris-code mailing list
opensolaris-code@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/opensolaris-code
