Recently, over in OpenAFS land, a issue arose with the OpenAFS code failing to build on snv due to a side effect of the August-ish introduction of NFS RDMA as a part of PSARC 2007/347.
In OpenAFS code, we have a struct we use called "conn". OpenAFS sucks in RPC and NFS-related header files as part of its AFS->NFS translator functionality. With the introduction of NFS RDMA, its attendant header file, rpc_rdma.h, introduces a struct of the same name[1]. Hence the build failure with the expected redefinition errors. I'm not sure what the general policy is regarding namespace of such things, and it could be that the NFS RDMA code is compliant in such regard... but I can't help but to think that giving that a name of "conn" is a bit too generic? Would "rdma_conn" be more appropriate? [1] http://src.opensolaris.org/source/xref/onnv/onnv-gate/usr/src/uts/common/rpc/rpc_rdma.h#329 _______________________________________________ opensolaris-code mailing list opensolaris-code@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/opensolaris-code
