First, thanks for the review!
JBeck> http://cr.opensolaris.org/~jbeck/mailwrapper/ Danek> Could you talk a bit about how a second / different MTA would interact Danek> with mailwrapper? I'm a bit confused about how mailer.conf delivers Danek> sendmail-specific configuration, but the sendmail package delivers Danek> generic links to mailwrapper; that seems backwards to me. Plus I don't Danek> see how installing, say, postfix, would switch (or allow a switch) the Danek> system to the new MTA. You would install the second / different MTA wherever, then update mailer.conf to point to its installation. From the discussion that you, Bart and I had in your office just now, I will defer the following suggestions to Ceri (though I will note that I see your arguments for them and I don't have any arguments against them): * Perhaps the usr/lib/sendmail sym-link should be moved from SUNWsndmu to SUNWmailwrapper? * Perhaps etc/mail/mailer.conf should be changed to a sym-link with the default target being etc/mail/mailer.conf-sendmail (which would be provided by SUNWsndmr), and sendmail's start method script would be responsible for making sure the sym-link target was correct? Likewise, other MTAs would have their start method scripts change the sym-link target to their own mailer.conf, e.g., etc/mail/mailer.conf-postfix . Danek> mailer.conf: Danek> - Section 4 is not likely where the man page would go. I'd expect it Danek> in mailwrapper(1), but if there's a separate page for the "subsystem", Danek> then it would go in section 5 on Solaris. Changed to: ... See mailwrapper(1m) and mailer.conf(4). Danek> SUNWmailwrapper-root/prototype_com: Danek> - line 48,49: given that the group perms don't differ from other perms, Danek> why specify group mail? Ditto in the usr package. Because I've generally used group mail for mail-related stuff in the past (see e.g. all sort of stuff under /etc/mail/), so I'm just continuing that practice. Danek> SUNWmailwrapper*/depend: Danek> - Copyright after cddl OK, I just copied that from the sndm? package depend file; I'm guessing that ordering rule must have been imposed after that file got CDDL-ized. Fixed. Danek> SUNWsndmu/depend: Danek> - update copyright and cddl block, remove ident line. Fixed. Danek> SUNWsndmu/prototype_com: Danek> - copyright should be 2009. Remove ident line. Fixed. -- John http://blogs.sun.com/jbeck _______________________________________________ opensolaris-code mailing list opensolaris-code@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/opensolaris-code