On 5/13/09, Roland Mainz <roland.ma...@nrubsig.org> wrote: > > Hi! > > ---- > > [<NOTE>Please note the _timeout_ is set to 2009-05-18 since we don't > have much time left anymore, after that point the code will re-synced > with OS/Net HEAD for final review and integration.</NOTE>] > > Here comes round "two" of the preliminary code review for the second > update of the ksh93 integration project (incorporating feedback by Alan > Coopersmik, Irek Szczesniak, Jennifer Pioch and Chris Pickett): I > created a webrev based on the 2009-05-11 snapshot of the > ksh93-integration prototype021 Subversion tree which is based on the > OS/Net Mercurial HEAD version. > > The webrev can be found at > http://cr.opensolaris.org/~gisburn/ksh93_integration_update2_20090511_webrev/ > , test binaries are available at > http://www.opensolaris.org/os/project/ksh93-integration/downloads/2009-05-11/ > and the HG export code chunk is available at > > http://www.opensolaris.org/os/project/ksh93-integration/downloads/ksh93_integration_update2_20090511_hg_export_001.hgexport.bz2 > (MD5 hash is "6c8f765ba7593c4d87aedf9cefca396a"). > > Notes: > - the following directories contain "upstream" sources which do not > require review (or require to be cstyled etc.):
Below you find my review: usr/src/cmd/ksh/builtins/alias.c line 38: #include <stdbool.h> is not required. The new file usr/src/tools/findunref/exception_list.subversion does not have a corresponding bug id. The change for usr/src/tools/scripts/Makefile does not have a corresponding bug id. usr/src/cmd/ksh/builtins/Makefile lines 98, 99: Is -z lazyload missing or do the global ON flags now do that? usr/src/lib/libshell/common/bltins/poll_solaris.c lines 142-147: Description for option -c does not match the function. The code returns an array and not a variable. usr/demo/ksh/tests should contain a short README which explains how to use the test suite. Please fix the spelling errors in shell_styleguide.docbook All other changes look good to me. Irek _______________________________________________ opensolaris-code mailing list opensolaris-code@opensolaris.org http://mail.opensolaris.org/mailman/listinfo/opensolaris-code
