>>>>> "DR" == Dean Roehrich <[EMAIL PROTECTED]> writes:
DR> On Wed, Oct 19, 2005 at 03:40:17PM -0700, Dan Price wrote:
>>
>> Hi Everyone,
>>
>> Codereview is a pillar of quality software development; the OpenSolaris
>> project does a good job of intensively reviewing changes today, but our
>> codereview process would would be even better if more codereviews
>> involved the wider community.
DR> Dan,
DR> Could you describe the usage model? I don't see hooks to a
DR> codestriker-type of thing. If someone puts something on grommit then
DR> what is the method for interested reviewers to know about it?
The poster tells people about it.
DR> Do reviewers need to have an account? Where should the review
DR> discussion happen?
DR> What is a 'webrev'? What is a 'wad'?
A webrev is the output generated by $SRC/tools/scripts/webrev.sh
(/opt/onbld/bin/webrev).
A wad is a set of changes. As in, I'm finishing up my kmdb wad, and am getting
ready to put back.
DR> Do people put unified or context diffs onto grommit, or do they put
DR> complete source files? Whole directories of the solaris tree?
Webrev generates both.
DR> Why is this model preferred over having people post unified diffs to a
DR> mailing list for review and discussion?
The webrev model is more flexible, as it provides access to several
different forms of diff, grouped in a way that's easier to read for large
changes. That said, if an implementor and the reviewers for a given wad decide
that they're going to use something else, they're more than welcome to.
Matt
--
Matt Simmons - [EMAIL PROTECTED] | Solaris Kernel - New York
Is it true that cannibals don't eat clowns
because they taste funny?
_______________________________________________
opensolaris-discuss mailing list
[email protected]
