Re: [osol-discuss] RFE: Relax "cstyle" limit of 80 characters in OS/Net...

[Casper . Dik]

>If you argue with terminals, you need to reduce the width to 79 as many 
>terminals cannot correctly display 80 columns. 

80 is fine for the majority of software terminals.

>What would happen if someone did write this:
>
>       if (dp == &notable) { 
>               /* BEGIN CSTYLED */
>               printf("Manufacturer is unknown because of the orange forum 
> embargo.\n"); 
>               printf("As the orange forum likes to get money for recent 
> information,\n"); 
>               printf("it may be that this media does not use illegal 
> manufacturer coding.\n"); 
>               /* END CSTYLED */
>       } 

Then CSTYLE would not barf but your code reviewers might.

In some cases, we have code which is formatted like this:

        if (dp == &notable) { 
printf("Manufacturer is unknown because of the orange forum embargo.\n");
printf("As the orange forum likes to get money for recent information,\n");
printf("it may be that this media does not use illegal manufacturer coding.\n");
        } 

But there's no particular reason, I think, why this can't be formatted like:

        if (dp == &notable) {
                (void) printf("Manufacturer is unknown because of the orange "
                    "forum embargo.\n"
                    "As the orange forum likes to get money for recent "
                    "information,\n"
                    "it may be that this media does not use illegal "
                    "manufacturer coding.\n");
        }

Casper
_______________________________________________
opensolaris-discuss mailing list
opensolaris-discuss@opensolaris.org