[email protected] wrote:
> I did noe see any request for review of the changed code. Are there no longer
> code reviews?
Nothing has changed in regards to code review policy - there has never
been a requirement in ON or most other consolidations [1] to expose reviews
to anyone but the reviewers - certainly you don't get cc'ed on every review
for the hundreds of changes integrating every build cycle, so I don't know
why you'd be surprised you didn't see review for these.
[1] The Desktop consolidations are the only exception I know of, with reviews
going to mailing lists with all active developers on - the jds-review list is
open, the X, CDE, & OpenWindows ones never have been. Some projects, like IPS,
encourage review on their project list, and some developers may choose to
request review from a public list, but that's a developer's choice, not a
requirement.
--
-Alan Coopersmith- [email protected]
Oracle Solaris Platform Engineering: X Window System
_______________________________________________
opensolaris-discuss mailing list
[email protected]