> On 2010-12-02 04:52:10, Boroondas Gupte wrote: > > > > Boroondas Gupte wrote: > EDITED TO ADD: (apparently Review Board can't handle comments on comments > on lines (sic!) and new comments on lines at the same time) > "The Review-Board diff view conveniently highlights them in red, so they > are hard to miss ;-)" > Of course, Review Board can't detect all whitespace mistakes:
Ah, I guess I should have read http://www.reviewboard.org/docs/manual/1.5/users/reviews/reviewing-diffs/#reading-existing-comments , first: "It’s important to note that this is meant to be used as a reference to see if other people have already said what you plan to say. The comment box is not the place to reply to those comments. Instead, you can click the Reply link next to the particular comment, which will take you back to the review request page and open a reply box." - Boroondas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://codereview.secondlife.com/r/2/#review10 ----------------------------------------------------------- On 2010-12-01 19:57:24, Oz Linden wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://codereview.secondlife.com/r/2/ > ----------------------------------------------------------- > > (Updated 2010-12-01 19:57:24) > > > Review request for Viewer. > > > Summary > ------- > > This review is mostly a first test of reviewboard. > > I do have an esthetic dislike for the 'break' statement anywhere but as the > end of a case, so I chose to change some instances of break usage that were > not justified by any extreme need. > > > This addresses bug storm-606. > http://jira.secondlife.com/browse/storm-606 > > > Diffs > ----- > > indra/newview/llappviewer.cpp bf98b026bcb1 > > Diff: http://codereview.secondlife.com/r/2/diff > > > Testing > ------- > > None at all... have not even compiled it yet. > > > Thanks, > > Oz > >
_______________________________________________ Policies and (un)subscribe information available here: http://wiki.secondlife.com/wiki/OpenSource-Dev Please read the policies before posting to keep unmoderated posting privileges
